Skip to content
This repository has been archived by the owner on Apr 20, 2023. It is now read-only.

Fix action modal on details page. #25

Merged
merged 1 commit into from
Sep 16, 2020

Conversation

sanis
Copy link
Contributor

@sanis sanis commented Sep 16, 2020

Hi,

I have noticed that action buttons on details page were broken after this commit:
cfcff0a

This happens because openConfirmationModal(action) does not exist on DetachedAction anymore, so it has to have call to the same determineActionStrategy(action) to trigger the same effect as on index page. Since selectedActionKey was not set anymore no action was called.

Also I have made changes to build project successfully:

composer install
npm i
npm run prod

@eoghanobrien eoghanobrien merged commit 0c48ff1 into gobrightspot:master Sep 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants