Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Makefile #7

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Refactor Makefile #7

wants to merge 2 commits into from

Conversation

AitorATuin
Copy link
Contributor

Removed the cpio in the Makefile.
Build distributed into several Makefiles.

@AitorATuin AitorATuin force-pushed the refactor_makefile branch 3 times, most recently from 351e0b1 to 48fb500 Compare August 28, 2016 20:49
@hishamhm
Copy link
Member

I don't like splitting the Makefiles. It's common to use a git checkout directly in /Programs/Scripts, meaning I'd end up with /bin/Makefile, etc.

Also, I'd prefer if it kept echoing the gcc commands. It's better for troubleshooting.

@AitorATuin AitorATuin force-pushed the refactor_makefile branch 2 times, most recently from c382624 to 9cfa246 Compare October 27, 2016 19:56
@AitorATuin
Copy link
Contributor Author

AitorATuin commented Oct 27, 2016 •
edited
Loading

@hishamhm @lucasvr Moved code to the main makefile and echoing building commands.

@AitorATuin AitorATuin force-pushed the refactor_makefile branch 2 times, most recently from 45fff11 to 0d104ff Compare October 27, 2016 20:35
hishamhm
hishamhm reviewed Oct 27, 2016
View reviewed changes
Makefile
done
cd $(PYTHON_SITE) && \
for f in *.py; \
do python -c "import `basename $$f .py`"; \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any particular reason for removing the generation of .pyc files?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ops! my bad! Added .pyc files generation again

@hishamhm
Copy link
Member

Reading this PR more carefully, if I'm following correctly, one thing it changes is that the files were moved around, so that one can't just clone the git repo at /Programs/Scripts/git, run make, run SymlinkProgram and use it directly without "installing" it from a separate directory.

I think it's very convenient to use the git repo as a "live" installation, and it would be sad to lose that functionality.

@AitorATuin AitorATuin force-pushed the refactor_makefile branch 2 times, most recently from 7971381 to d75501f Compare January 18, 2017 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hishamhm hishamhm hishamhm left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AitorATuin @hishamhm