Marshal array_map in Base, only collect entries when needed
#933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vated. Only if this configuration option is active, the array-domain should be chosen selectively. Note that the option is activated by the autotuner in case it itself adds these annotations.
michael-schwarz
approved these changes
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the Base so that the
array_mapis marshalled. Additionally, it ensures that entries for this map are only collected when needed, i.e. when "annotation.goblint_array_domain" is activated. Only if this configuration option is active, the array-domain should be chosen selectively. Note that the option is activated by the autotuner case it itself adds these annotations.This PR fixes #932, but I was not able to construct a small test case that exhibits the issue of #932, so this PR does not add any regression tests.