Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

website/docs: fix missing breaking entry for 2025.2 release notes #13223

Merged
merged 2 commits into from
Feb 24, 2025

Conversation

BeryJu
Copy link
Member

@BeryJu BeryJu commented Feb 24, 2025

Details

see #12875


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu requested a review from a team as a code owner February 24, 2025 15:17
@BeryJu
Copy link
Member Author

BeryJu commented Feb 24, 2025

/cherry-pick version-2025.2

Copy link

netlify bot commented Feb 24, 2025

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit bba30b0
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/67bc90dd5bdebd0008e736ec
😎 Deploy Preview https://deploy-preview-13223--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 24, 2025

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit bba30b0
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/67bc90dd6b8cd80008fd2e76

Copy link

codecov bot commented Feb 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.65%. Comparing base (6da55dc) to head (bba30b0).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13223      +/-   ##
==========================================
- Coverage   92.71%   92.65%   -0.07%     
==========================================
  Files         792      792              
  Lines       40231    40231              
==========================================
- Hits        37301    37275      -26     
- Misses       2930     2956      +26     
Flag Coverage Δ
e2e 48.02% <ø> (-0.14%) ⬇️
integration 24.13% <ø> (ø)
unit 90.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -13,6 +13,12 @@ slug: "/releases/2025.2"

## Breaking changes

- **Fixed behaviour in Source stage <span class="badge badge--primary">Enterprise</span>**

In previous versions, the Source stage would incorrectly continue with the initial flow after returning from the source, which didn't match the documented behaviour.
Copy link
Contributor

@tanberry tanberry Feb 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What exactly does "returning from the source" mean"? Does this mean after retrieving credentials for authz from the source, or...?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after the source redirects back to authentik

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, LGTM, I think most will understand it but I need to learn more.

Co-authored-by: Tana M Berry <tanamarieberry@yahoo.com>
Signed-off-by: Jens L. <jens@beryju.org>
Copy link
Contributor

@tanberry tanberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@BeryJu BeryJu merged commit 93b9351 into main Feb 24, 2025
80 of 81 checks passed
@BeryJu BeryJu deleted the website/docs/fix-missing-breaking branch February 24, 2025 15:47
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Feb 24, 2025
…3223)

* website/docs: fix missing breaking entry for 2025.2 release notes

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

* Update website/docs/releases/2025/v2025.2.md

Co-authored-by: Tana M Berry <tanamarieberry@yahoo.com>
Signed-off-by: Jens L. <jens@beryju.org>

---------

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens L. <jens@beryju.org>
Co-authored-by: Tana M Berry <tanamarieberry@yahoo.com>
BeryJu added a commit that referenced this pull request Feb 24, 2025
…erry-pick #13223) (#13224)

website/docs: fix missing breaking entry for 2025.2 release notes (#13223)

* website/docs: fix missing breaking entry for 2025.2 release notes



* Update website/docs/releases/2025/v2025.2.md




---------

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens L. <jens@beryju.org>
Co-authored-by: Jens L. <jens@goauthentik.io>
Co-authored-by: Tana M Berry <tanamarieberry@yahoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants