Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor locale and fix ci #433

Merged
merged 8 commits into from
Jul 30, 2024
Merged

refactor locale and fix ci #433

merged 8 commits into from
Jul 30, 2024

Conversation

goatshriek
Copy link
Owner

Refactors the locale github actions workflow to use a matrix strategy, making it much shorter.

This also includes a fix to an incorrect use of the -C argument to ctest, which started failing in some environments.

@goatshriek goatshriek added the build pertains to the configuration and build stages label Jul 30, 2024
@goatshriek goatshriek self-assigned this Jul 30, 2024
Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.85%. Comparing base (8d1f007) to head (e963445).

Additional details and impacted files
@@           Coverage Diff           @@
##           latest     #433   +/-   ##
=======================================
  Coverage   90.85%   90.85%           
=======================================
  Files          47       47           
  Lines        4384     4384           
  Branches      586      586           
=======================================
  Hits         3983     3983           
  Misses        269      269           
  Partials      132      132           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@goatshriek goatshriek added the bug something is broken or missing label Jul 30, 2024
Copy link

@goatshriek goatshriek merged commit f8830d6 into latest Jul 30, 2024
86 checks passed
@goatshriek goatshriek deleted the locale-ci branch July 30, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something is broken or missing build pertains to the configuration and build stages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant