Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong format on srt #20

Open
niklasnilsson87 opened this issue Feb 16, 2021 · 2 comments
Open

Wrong format on srt #20

niklasnilsson87 opened this issue Feb 16, 2021 · 2 comments

Comments

@niklasnilsson87
Copy link

if I send in

1
00:00:13,960 --> 00:00:18,416
I cannot believe it.

It throws an error, Isn't the correct format on srt with a " , " at millisecond?

@gregmsanderson
Copy link

Yep, you are right. I've just found the same. A valid .srt file fails to parse because of that.

Guessing it's a result of the regex checking for a WebVTT-style time (so not allowing a comma):

https://github.com/goatandsheep/node-srt/blob/master/lib/parser.js#L14

kms0219kms added a commit to waktaplay/node-srt-ts that referenced this issue Aug 24, 2024
…, a bug that occurred when parsing srt files written in comma-separated millisecond time format.
kms0219kms added a commit to waktaplay/node-srt-ts that referenced this issue Aug 24, 2024
…rred when parsing srt files written in comma-separated millisecond time format.
kms0219kms added a commit to waktaplay/node-srt-ts that referenced this issue Aug 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants