-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong format on srt #20
Comments
Yep, you are right. I've just found the same. A valid .srt file fails to parse because of that. Guessing it's a result of the regex checking for a WebVTT-style time (so not allowing a comma): https://github.com/goatandsheep/node-srt/blob/master/lib/parser.js#L14 |
…, a bug that occurred when parsing srt files written in comma-separated millisecond time format.
@niklasnilsson87 @gregmsanderson I just replaced all Can you try in this way? |
…rred when parsing srt files written in comma-separated millisecond time format.
if I send in
It throws an error, Isn't the correct format on srt with a " , " at millisecond?
The text was updated successfully, but these errors were encountered: