suggestions on typing PR #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlambert03
commented
May 28, 2021
| @@ -162,7 +162,6 @@ def test_settings_env_variables(tmp_path, monkeypatch): | |||
| value = 'light' | |||
| monkeypatch.setenv('NAPARI_THEME', value) | |||
| settings = SettingsManager(tmp_path, save_to_disk=True) | |||
| assert CORE_SETTINGS[0]().theme == value | |||
There was a problem hiding this comment.
removed this here cause it feels repetitive... but if you wanted to keep it in, you'd need to do somethiing like
appearance: AppearanceSettings = CORE_SETTINGS[0]()
assert appearance.theme == value
goanpeca
force-pushed
the
enh/a-little-typing
branch
3 times, most recently
from
7f9b5ee
to
b8b02c3
Compare
goanpeca
pushed a commit
that referenced
this pull request
Sep 21, 2022
* Update discussion points * Change status to accepted * No default sync slicing * Expand API of requests and responses * Clarify why thumbnail is in the response * Upper case subtitle * Clarify one slicer per viewer * Expand potential design of asap rendering * Fix input state * Update discussion with screenshot stuff * Update resolution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
some thoughts