-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement biometrics (#15) #20
Open
Berna-L
wants to merge
11
commits into
goaaats:master
Choose a base branch
from
Berna-L:biometrics
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Finished up the implementation and got my environment to work on real devices, so I tested on both a Galaxy A10s (with fingerprint sensor) and an iPhone 14 Pro, but further testing is welcome (and desirable). |
Generated a local IPA and installed on my device through AltStore. The only issues (both caused by recent Xcode 14.3, so they may be fixed in a future Flutter build) are: |
Now, it'll basically shoot the OTP at the same time to all registered IPs. Since any IP that actually has XL waiting for the code will reply quickly, it'll return true if any client received the code. If no client is running, any fail response is good.
…cation to biometrics only.
- Update SDK version - Change MainActivity superclass to FlutterFragmentActivity (see https://pub.dev/documentation/local_auth/latest/ -> Activity Changes) - Change AndroidManifest.xml to add android:exported="true" (required for Android 12+) - Do not let user use the application until they authenticate - Make the biometrics option centered.
+ Rename Authentication class to Biometrics.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implementation adds an option to the settings page to require biometrics (on devices that offer such a feature).
When enabled (and enabling it requires authentication, BTW):
This also includes the commits from #21 .