Deal with empty Identity for ROUTER socket #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, need to assign a uuid in those case additionally, remove sck.ids, which seems to be leaking and unused
superfashi
force-pushed
the
empty-identity
branch
from
47f7fae to
9381545
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #140 +/- ##
==========================================
- Coverage 67.43% 67.06% -0.37%
==========================================
Files 29 29
Lines 1821 1819 -2
==========================================
- Hits 1228 1220 -8
- Misses 490 495 +5
- Partials 103 104 +1
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
sbinet
approved these changes
Apr 7, 2023
|
needed go-zeromq/license#15 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default,
libzmqimplementation sends empty Identity. Also inlibzmqimplementation, when a server receives an empty Identity for Router connections, it falls back to auto generation. Otherwise, the Router socket will by large chance misbehave.See: https://github.com/zeromq/libzmq/blob/master/src/router.cpp#L481-L487
Additionally, remove
sck.ids, which is unused and leaks*Conn.