-
-
Notifications
You must be signed in to change notification settings - Fork 65
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(views): remove default filter from frontend, apply by default to …
…new list views instead (#2240) Fixes #2234 Co-authored-by: Daniel Herrmann <daniel.herrmann1@gmail.com> Reviewed-on: https://kolaente.dev/vikunja/vikunja/pulls/2240 Reviewed-by: konrad <k@knt.li> Co-authored-by: waza-ari <daniel.herrmann@makerspace-darmstadt.de> Co-committed-by: waza-ari <daniel.herrmann@makerspace-darmstadt.de>
- Loading branch information
Showing
3 changed files
with
53 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
// Vikunja is a to-do list application to facilitate your life. | ||
// Copyright 2018-present Vikunja and contributors. All rights reserved. | ||
// | ||
// This program is free software: you can redistribute it and/or modify | ||
// it under the terms of the GNU Affero General Public Licensee as published by | ||
// the Free Software Foundation, either version 3 of the License, or | ||
// (at your option) any later version. | ||
// | ||
// This program is distributed in the hope that it will be useful, | ||
// but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
// GNU Affero General Public Licensee for more details. | ||
// | ||
// You should have received a copy of the GNU Affero General Public Licensee | ||
// along with this program. If not, see <https://www.gnu.org/licenses/>. | ||
|
||
package migration | ||
|
||
import ( | ||
"src.techknowlogick.com/xormigrate" | ||
"xorm.io/xorm" | ||
) | ||
|
||
type projectView20240329170952 struct { | ||
ID int64 `xorm:"autoincr not null unique pk" json:"id" param:"view"` | ||
Filter string `xorm:"text null default null" query:"filter" json:"filter"` | ||
ViewKind int `xorm:"not null" json:"view_kind"` | ||
} | ||
|
||
func (projectView20240329170952) TableName() string { | ||
return "project_views" | ||
} | ||
|
||
func init() { | ||
migrations = append(migrations, &xormigrate.Migration{ | ||
ID: "20240329170952", | ||
Description: "Update default filter for list views to hide completed tasks", | ||
Migrate: func(tx *xorm.Engine) error { | ||
|
||
// Update the filter for all list views to hide completed tasks unless the filter is already set | ||
_, err := tx.Where("view_kind = ? AND filter = ?", 0, "").Cols("filter").Update(&projectView20240329170952{Filter: "done = false"}) | ||
if err != nil { | ||
return err | ||
} | ||
return nil | ||
}, | ||
Rollback: func(tx *xorm.Engine) error { | ||
return nil | ||
}, | ||
}) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters