Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial push #1

Merged
merged 14 commits into from
Mar 14, 2022
Merged

Initial push #1

merged 14 commits into from
Mar 14, 2022

Conversation

Cappo
Copy link
Contributor

@Cappo Cappo commented Jan 19, 2022

Contains the code for the vela-npm plugin for publishing Node.JS packages.

Basic usage:

steps:
  - name: publish to npm
    image: target/vela-npm
    secrets: [ npm_token ]

build/Dockerfile Outdated Show resolved Hide resolved
Copy link
Contributor

@kaymckay kaymckay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented on some little things, but other than that looks good 👍 I noticed the workflows didn't run because you are PRing from a forked repo, so I would run golangci, that one always complains about something

cmd/vela-npm/main.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jan 24, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@adb2089). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main       #1   +/-   ##
=======================================
  Coverage        ?   62.52%           
=======================================
  Files           ?        3           
  Lines           ?      451           
  Branches        ?        0           
=======================================
  Hits            ?      282           
  Misses          ?      141           
  Partials        ?       28           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adb2089...bc30bcf. Read the comment docs.

kaymckay
kaymckay previously approved these changes Jan 24, 2022
Copy link
Contributor

@kaymckay kaymckay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the changes 👍

go.mod Outdated Show resolved Hide resolved
kaymckay
kaymckay previously approved these changes Mar 1, 2022
Copy link
Contributor

@kaymckay kaymckay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Collaborator

@wass3r wass3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@wass3r wass3r merged commit 1c2eaa5 into go-vela:main Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants