-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial push #1
Initial push #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commented on some little things, but other than that looks good 👍 I noticed the workflows didn't run because you are PRing from a forked repo, so I would run golangci, that one always complains about something
Codecov Report
@@ Coverage Diff @@
## main #1 +/- ##
=======================================
Coverage ? 62.52%
=======================================
Files ? 3
Lines ? 451
Branches ? 0
=======================================
Hits ? 282
Misses ? 141
Partials ? 28 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for the changes 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
Contains the code for the
vela-npm
plugin for publishing Node.JS packages.Basic usage: