Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: post-merge linter fixes #257

Merged
merged 2 commits into from
Jan 22, 2021
Merged

fix: post-merge linter fixes #257

merged 2 commits into from
Jan 22, 2021

Conversation

wass3r
Copy link
Collaborator

@wass3r wass3r commented Jan 21, 2021

small fix-up for #246 as indicated in the discussion on that story

@wass3r wass3r requested a review from a team as a code owner January 21, 2021 22:47
@codecov
Copy link

codecov bot commented Jan 21, 2021

Codecov Report

Merging #257 (a8c2b62) into master (6053428) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #257      +/-   ##
==========================================
- Coverage   86.87%   86.81%   -0.06%     
==========================================
  Files         117      117              
  Lines        2918     2920       +2     
==========================================
  Hits         2535     2535              
- Misses        315      316       +1     
- Partials       68       69       +1     
Impacted Files Coverage Δ
source/github/authentication.go 82.60% <0.00%> (-3.76%) ⬇️

Copy link
Contributor

@jbrockopp jbrockopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wass3r wass3r merged commit a88a5d8 into master Jan 22, 2021
@wass3r wass3r deleted the fix/pat branch January 22, 2021 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants