Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(deploy): validate on CreateDeployment #1236

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

ecrupper
Copy link
Contributor

@ecrupper ecrupper commented Jan 8, 2025

Give a response on an invalid deployment on creation rather than letting the webhook handler deal with it all the time.

@ecrupper ecrupper requested a review from a team as a code owner January 8, 2025 14:00
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 0% with 37 lines in your changes missing coverage. Please review.

Project coverage is 56.57%. Comparing base (f34ffb9) to head (99942e4).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
api/deployment/create.go 0.00% 20 Missing ⚠️
api/deployment/get_config.go 0.00% 16 Missing ⚠️
compiler/types/pipeline/deployment.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1236      +/-   ##
==========================================
- Coverage   56.60%   56.57%   -0.03%     
==========================================
  Files         628      628              
  Lines       35578    35596      +18     
==========================================
  Hits        20139    20139              
- Misses      14759    14777      +18     
  Partials      680      680              
Files with missing lines Coverage Δ
compiler/types/pipeline/deployment.go 89.28% <0.00%> (ø)
api/deployment/get_config.go 0.00% <0.00%> (ø)
api/deployment/create.go 0.00% <0.00%> (ø)

Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ecrupper ecrupper merged commit 355199f into main Jan 8, 2025
11 of 13 checks passed
@ecrupper ecrupper deleted the enhance/validate-deploy-on-create branch January 8, 2025 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants