Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: supply parent context to scm funcs #1169

Merged
merged 6 commits into from
Aug 19, 2024
Merged

enhance: supply parent context to scm funcs #1169

merged 6 commits into from
Aug 19, 2024

Conversation

plyr4
Copy link
Contributor

@plyr4 plyr4 commented Aug 13, 2024

splitting out more context propagation from #899

@plyr4 plyr4 requested a review from a team as a code owner August 13, 2024 15:00
Copy link

codecov bot commented Aug 13, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 32 lines in your changes missing coverage. Please review.

Project coverage is 52.11%. Comparing base (8a04a89) to head (bb7849e).
Report is 1 commits behind head on main.

Files Patch % Lines
api/build/compile_publish.go 0.00% 17 Missing ⚠️
scm/github/deployment.go 25.00% 3 Missing ⚠️
api/pipeline/compile.go 0.00% 2 Missing ⚠️
api/pipeline/expand.go 0.00% 2 Missing ⚠️
api/pipeline/validate.go 0.00% 2 Missing ⚠️
compiler/native/expand.go 80.00% 2 Missing ⚠️
api/build/graph.go 0.00% 1 Missing ⚠️
api/pipeline/template.go 0.00% 1 Missing ⚠️
scm/github/repo.go 91.66% 1 Missing ⚠️
scm/github/user.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1169      +/-   ##
==========================================
- Coverage   52.12%   52.11%   -0.01%     
==========================================
  Files         550      550              
  Lines       18856    18859       +3     
==========================================
  Hits         9828     9828              
- Misses       8466     8469       +3     
  Partials      562      562              
Files Coverage Δ
compiler/native/compile.go 71.63% <100.00%> (ø)
compiler/native/native.go 88.63% <100.00%> (ø)
compiler/registry/github/github.go 100.00% <100.00%> (ø)
compiler/registry/github/template.go 53.84% <100.00%> (ø)
router/middleware/pipeline/pipeline.go 82.22% <100.00%> (ø)
scm/github/access.go 82.72% <100.00%> (ø)
scm/github/authentication.go 82.27% <100.00%> (ø)
scm/github/changeset.go 86.11% <100.00%> (ø)
scm/github/github.go 100.00% <100.00%> (ø)
scm/github/org.go 87.50% <100.00%> (ø)
... and 11 more

@plyr4 plyr4 changed the title enhance: supply parent context to scm client creation enhance: supply parent context to scm funcs Aug 13, 2024
Copy link
Member

@wass3rw3rk wass3rw3rk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

9068pn

@plyr4 plyr4 merged commit 8b07da9 into main Aug 19, 2024
11 of 13 checks passed
@plyr4 plyr4 deleted the enhance/ctx-gh branch August 19, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants