Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: supply parent context to all db calls #1168

Merged
merged 5 commits into from
Aug 21, 2024
Merged

enhance: supply parent context to all db calls #1168

merged 5 commits into from
Aug 21, 2024

Conversation

plyr4
Copy link
Contributor

@plyr4 plyr4 commented Aug 13, 2024

required for grouping otel gorm spans into the parent trace, see: #899

@plyr4 plyr4 requested a review from a team as a code owner August 13, 2024 14:39
Copy link

codecov bot commented Aug 13, 2024

Codecov Report

Attention: Patch coverage is 99.00990% with 4 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@563ff52). Learn more about missing BASE report.

Files Patch % Lines
database/deployment/get.go 50.00% 1 Missing ⚠️
database/deployment/get_repo.go 50.00% 1 Missing ⚠️
database/deployment/list.go 50.00% 1 Missing ⚠️
database/deployment/list_repo.go 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1168   +/-   ##
=======================================
  Coverage        ?   52.95%           
=======================================
  Files           ?      550           
  Lines           ?    19151           
  Branches        ?        0           
=======================================
  Hits            ?    10142           
  Misses          ?     8447           
  Partials        ?      562           
Files Coverage Δ
database/build/clean.go 100.00% <100.00%> (ø)
database/build/count.go 100.00% <100.00%> (ø)
database/build/count_deployment.go 100.00% <100.00%> (ø)
database/build/count_org.go 100.00% <100.00%> (ø)
database/build/count_repo.go 100.00% <100.00%> (ø)
database/build/count_status.go 100.00% <100.00%> (ø)
database/build/create.go 77.77% <100.00%> (ø)
database/build/delete.go 100.00% <100.00%> (ø)
database/build/get.go 88.23% <100.00%> (ø)
database/build/get_repo.go 90.90% <100.00%> (ø)
... and 163 more

Copy link
Contributor

@ecrupper ecrupper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ecrupper.WithContext(ctx).approves()

Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@plyr4 plyr4 merged commit 77ee0a7 into main Aug 21, 2024
14 of 16 checks passed
@plyr4 plyr4 deleted the enhance/db-ctx branch August 21, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants