Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(db/types): add check before owner decrypt #1166

Merged
merged 2 commits into from
Aug 26, 2024
Merged

fix(db/types): add check before owner decrypt #1166

merged 2 commits into from
Aug 26, 2024

Conversation

wass3r
Copy link
Collaborator

@wass3r wass3r commented Aug 12, 2024

note: we don't actually return an error, we just log it, but it adds a bit of unnecessary noise.

@wass3r wass3r requested a review from a team as a code owner August 12, 2024 02:04
Copy link

codecov bot commented Aug 12, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 52.93%. Comparing base (77ee0a7) to head (44b54e5).
Report is 1 commits behind head on main.

Files Patch % Lines
database/types/repo.go 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1166      +/-   ##
==========================================
- Coverage   52.95%   52.93%   -0.02%     
==========================================
  Files         550      550              
  Lines       19151    19152       +1     
==========================================
- Hits        10142    10139       -3     
- Misses       8447     8449       +2     
- Partials      562      564       +2     
Files Coverage Δ
database/types/repo.go 97.03% <50.00%> (+0.02%) ⬆️

... and 2 files with indirect coverage changes

@wass3r wass3r self-assigned this Aug 12, 2024
@wass3rw3rk wass3rw3rk merged commit 0f28017 into main Aug 26, 2024
13 of 15 checks passed
@wass3rw3rk wass3rw3rk deleted the fix/db-owner branch August 26, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants