Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use builtin min/max funcs #1148

Merged
merged 8 commits into from
Aug 20, 2024

Merge branch 'main' into refactor/use-go-minmax

eb42802
Select commit
Loading
Failed to load commit list.
Merged

refactor: use builtin min/max funcs #1148

Merge branch 'main' into refactor/use-go-minmax
eb42802
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Aug 20, 2024 in 0s

52.18% (target 90.00%)

View this Pull Request on Codecov

52.18% (target 90.00%)

Details

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.

Project coverage is 52.18%. Comparing base (8b07da9) to head (eb42802).

Files Patch % Lines
api/repo/update.go 0.00% 4 Missing ⚠️
api/build/list_org.go 0.00% 1 Missing ⚠️
api/build/list_repo.go 0.00% 1 Missing ⚠️
api/deployment/list.go 0.00% 1 Missing ⚠️
api/hook/list.go 0.00% 1 Missing ⚠️
api/log/list_build.go 0.00% 1 Missing ⚠️
api/pipeline/list.go 0.00% 1 Missing ⚠️
api/repo/list.go 0.00% 1 Missing ⚠️
api/repo/list_org.go 0.00% 1 Missing ⚠️
api/schedule/list.go 0.00% 1 Missing ⚠️
... and 4 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1148      +/-   ##
==========================================
+ Coverage   52.11%   52.18%   +0.07%     
==========================================
  Files         550      550              
  Lines       18859    18833      -26     
==========================================
  Hits         9828     9828              
+ Misses       8469     8443      -26     
  Partials      562      562              
Files Coverage Δ
util/util.go 18.86% <ø> (+2.47%) ⬆️
api/build/list_org.go 0.00% <0.00%> (ø)
api/build/list_repo.go 0.00% <0.00%> (ø)
api/deployment/list.go 0.00% <0.00%> (ø)
api/hook/list.go 0.00% <0.00%> (ø)
api/log/list_build.go 0.00% <0.00%> (ø)
api/pipeline/list.go 0.00% <0.00%> (ø)
api/repo/list.go 0.00% <0.00%> (ø)
api/repo/list_org.go 0.00% <0.00%> (ø)
api/schedule/list.go 0.00% <0.00%> (ø)
... and 5 more