fix: remove unused var

go-vela · Aug 26, 2024 · 33bf135 · 33bf135
1 parent bac7ab8
commit 33bf135
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 8 deletions.
diff --git a/docker-compose.yml b/docker-compose.yml
@@ -50,7 +50,6 @@ services:
       VELA_OTEL_TRACING_SERVICE_NAME: vela-server
       VELA_OTEL_TRACING_RESOURCE_ATTRIBUTES: "process.runtime.name=go"
       VELA_OTEL_TRACING_RESOURCE_ENV_ATTRIBUTES: "deployment.environment=CLOUD_ENVIRONMENT"
-      VELA_OTEL_TRACING_SAMPLER_RATIO: 1
       VELA_OTEL_TRACING_SAMPLER_RATELIMIT_PER_SECOND: 0.2
     env_file:
       - .env

diff --git a/tracing/flags.go b/tracing/flags.go
@@ -71,16 +71,10 @@ var Flags = []cli.Flag{
 		Usage:   "set otel sampler type attribute attached to each span.",
 		Value:   "sampler.type",
 	},
-	&cli.Float64Flag{
-		EnvVars: []string{"VELA_OTEL_TRACING_SAMPLER_RATIO"},
-		Name:    "tracing.sampler.ratio",
-		Usage:   "set otel tracing head-sampler acceptance ratio. see: https://opentelemetry.io/docs/concepts/sampling/",
-		Value:   0.5,
-	},
 	&cli.Float64Flag{
 		EnvVars: []string{"VELA_OTEL_TRACING_SAMPLER_RATELIMIT_PER_SECOND"},
 		Name:    "tracing.sampler.persecond",
 		Usage:   "set otel tracing head-sampler rate-limiting to N per second. see: https://opentelemetry.io/docs/concepts/sampling/",
-		Value:   1,
+		Value:   0.2,
 	},
 }