-
-
Notifications
You must be signed in to change notification settings - Fork 612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for exclude rules for sources #309
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @lunny, thanks for opening this pull request!
Unfortunately, there are changes required before this can be merged:
- You should target
v3
instead ofmaster
- You shouldn't touch the
vendor
directory (it's frozen onv3
and will be removed before releasing) - We definitely shouldn't use two glob libraries at the same time! I vote to try keeping the existing one if possible.
After these changes, I'll review again. 🙂
|
@andreynering done. |
Closed by mistake, sorry |
Hello, what is the status of this PR? From #225 I understand it is complicated, but I have hope :-) |
@andreynering is there any updates on this issue? Having something to exclude is quite a nice feature to have. |
@andreynering is there anything I could do to help with driving this forward? It would be a crucial feature for me as currently code generation patterns (e.g. generating |
How promising does helping getting mattn/go-zglob#30 landed go towards solving this? |
When I use task to package a directory which includes
node_modules
, I found it will spend about 7 seconds even if I have setsources
. And I found that's becausetask
needs exclude rules, so I write this PR and now I can set as below:After the change, it will spend only
0.29s
. Yeah!