Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update changelog for releasing v1.8.1 (#1576) #1577

Merged

Conversation

shogo82148
Copy link
Contributor

@shogo82148 shogo82148 commented Mar 26, 2024

cherry pick of shogo82148@476df92

Summary by CodeRabbit

  • Bug Fixes
    • Addressed race conditions when the context is canceled.
  • New Features
    • Enhanced database connection with charset and collation settings.
    • Improved path escaping in database names.
    • Dropped support for Go versions 1.13-17.
    • Implemented parsing numbers over text protocol.
    • Introduced new configuration options for advanced usage.
  • Enhancements
    • Made logger configurable per connection.
    • Fixed handling of mediumint unsigned in ColumnType.DatabaseTypeName.
    • Added connection attributes for more detailed connection information.

### Description

go-sql-driver#1559 and
go-sql-driver#1567 are fixed.
Let's release a new version v1.8.1.

### Checklist
- [x] Code compiles correctly
- [x] Created tests which fail without the change (if possible)
- [x] All tests passing
- [x] Extended the README / documentation, if necessary
- [x] Added myself / the copyright holder to the AUTHORS file


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Bug Fixes**
	- Addressed race condition issues for enhanced stability.

- **New Features**
- Improved database compatibility with charset and collation
adjustments.
- Enhanced security and flexibility through the introduction of new
configuration options.

- **Major Changes**
- Dropped support for older versions of Go (1.13-1.17) to leverage newer
language features.
	- Improved number parsing for efficiency and accuracy.
	- Added configurable logging per connection for better diagnostics.

- **Enhancements**
- Fixed issues with ColumnType.DatabaseTypeName to improve data
handling.
- Introduced connection attributes for more detailed connection
information.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Copy link

coderabbitai bot commented Mar 26, 2024

Walkthrough

The recent updates focus on enhancing stability and compatibility. Version 1.8.1 brings crucial bugfixes to address race conditions related to context cancellation. Meanwhile, version 1.8.0 introduces significant changes, such as improved database character set support, dropping older Go versions, and new functional options for better configuration. Additionally, other updates include a more versatile logger, corrected data type naming for mediumint unsigned, the addition of connection attributes, and several other improvements, aiming to refine the overall functionality and user experience.

Changes

Files Change Summaries
Various Bugfixes: Addressed race conditions when context is canceled in v1.8.1.
Various Major Changes: Introduced in v1.8.0, including SET NAMES charset COLLATE collation, PathEscaping dbname in DSN, dropping Go 1.13-17 support, parsing numbers on the text protocol, and new options with Functional Option Pattern.
Various Other Changes: Enhancements such as configurable logger per connection, fixing ColumnType.DatabaseTypeName for mediumint unsigned, adding connection attributes, and more.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between d7ddb8b and 476df92.
Files selected for processing (1)
  • CHANGELOG.md (1 hunks)
Additional comments: 3
CHANGELOG.md (3)
  • 1-42: The changelog is well-structured and provides a clear overview of changes across versions. However, consider the following formatting improvements for consistency and clarity:
  • Ensure consistent use of spaces after hyphens in lists.
  • Verify the correctness of all external links to pull requests to ensure they are accessible.
  • Attribute contributions consistently, starting with an uppercase letter after the hyphen for each list item.
  • 5-5: The documentation of the race condition fix in PRs fix race condition when context is canceled #1562 and Fix issue 1567 #1570 under version 1.8.1 accurately reflects the collective effort to address this issue, as noted in the provided learning. This clear attribution helps users understand the context and significance of the changes.
  • 1-42: While reviewing the changelog, ensure that all technical terms and references are used correctly, and consider rephrasing for clarity if necessary. However, be cautious of false positives from automated tools, especially regarding technical content and code references, which may not apply to the structured and technical nature of a changelog.

@coveralls
Copy link

Coverage Status

coverage: 82.462%. remained the same
when pulling 476df92 on shogo82148:update-changelog-for-v1.8.1
into d7ddb8b on go-sql-driver:master.

@shogo82148 shogo82148 merged commit 8d421d9 into go-sql-driver:master Apr 30, 2024
32 checks passed
@shogo82148 shogo82148 deleted the update-changelog-for-v1.8.1 branch April 30, 2024 02:54
methane pushed a commit to methane/mysql that referenced this pull request Apr 30, 2024
…iver#1577)

cherry pick of
shogo82148@476df92

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Bug Fixes**
	- Addressed race conditions when the context is canceled.
- **New Features**
	- Enhanced database connection with charset and collation settings.
	- Improved path escaping in database names.
	- Dropped support for Go versions 1.13-17.
	- Implemented parsing numbers over text protocol.
	- Introduced new configuration options for advanced usage.
- **Enhancements**
	- Made logger configurable per connection.
- Fixed handling of `mediumint unsigned` in
`ColumnType.DatabaseTypeName`.
	- Added connection attributes for more detailed connection information.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants