Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in the comment of mysqlConn.cancel(): 'finish' should be 'cancel' #1646

Closed
minhquang4334 opened this issue Dec 15, 2024 · 0 comments · Fixed by #1647
Closed

Typo in the comment of mysqlConn.cancel(): 'finish' should be 'cancel' #1646

minhquang4334 opened this issue Dec 15, 2024 · 0 comments · Fixed by #1647

Comments

@minhquang4334
Copy link
Contributor

Issue description

There is a typo in the comment of mysqlConn.cancel()
https://github.com/go-sql-driver/mysql/blob/master/connection.go#L438

Example code

// finish is called when the query has canceled.
func (mc *mysqlConn) cancel(err error) {
	mc.canceled.Set(err)
	mc.cleanup()
}

Error log

If you have an error log, please paste it here.

Configuration

Driver version (or git SHA): 1.8.1

Go version: run go version in your console

Server version: E.g. MySQL 5.6, MariaDB 10.0.20

Server OS: E.g. Debian 8.1 (Jessie), Windows 10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant