Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:allow authentication using proxy request header #860

Open
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

PterX
Copy link

@PterX PterX commented Mar 18, 2024

description : #836

Due to improper robot settings, my pr was forcibly updated and the pr was not merged properly.

wrong merge: PterX#4

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

Attention: Patch coverage is 6.66667% with 84 lines in your changes are missing coverage. Please review.

Project coverage is 30.40%. Comparing base (595cb45) to head (f44354b).
Report is 24 commits behind head on master.

Files Patch % Lines
internal/http/middleware/auth.go 13.95% 37 Missing ⚠️
internal/http/middleware/cidrs.go 0.00% 25 Missing ⚠️
internal/webserver/handler.go 0.00% 13 Missing ⚠️
internal/webserver/handler-api.go 0.00% 8 Missing ⚠️
internal/http/server.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #860      +/-   ##
==========================================
+ Coverage   25.58%   30.40%   +4.82%     
==========================================
  Files          47       63      +16     
  Lines        5628     4535    -1093     
==========================================
- Hits         1440     1379      -61     
+ Misses       3989     2934    -1055     
- Partials      199      222      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dfeyer
Copy link

dfeyer commented Mar 18, 2024

Love that feature, will make it super nice to integrate behing a Traefik prox with Auth forwarding to Authentik ... thanks for the contribution.

@PterX PterX force-pushed the proxy_auth branch 2 times, most recently from fef26a9 to 064cc04 Compare March 25, 2024 23:41
@PterX PterX changed the title allow authentication using proxy request header feat:allow authentication using proxy request header Apr 12, 2024
@PterX PterX requested a review from dfeyer April 12, 2024 14:31
@fmartingr
Copy link
Member

Hey @PterX thanks for keeping this up to date, I have not forgotten about it but I had to fix other things first.

Do you think you could add a basic Authelia service to the docker-compose file to ease the testing of this? It's ok if you are not comfortable with that. I'm in the process to set up Authelia in my own environment too so I could get into this once I have that running since this is of interest to me as well.

@codecov-commenter
Copy link

codecov-commenter commented May 23, 2024

Codecov Report

Attention: Patch coverage is 6.66667% with 84 lines in your changes missing coverage. Please review.

Project coverage is 34.14%. Comparing base (9aa8332) to head (c5a0784).

Files Patch % Lines
internal/http/middleware/auth.go 13.95% 37 Missing ⚠️
internal/http/middleware/cidrs.go 0.00% 25 Missing ⚠️
internal/webserver/handler.go 0.00% 13 Missing ⚠️
internal/webserver/handler-api.go 0.00% 8 Missing ⚠️
internal/http/server.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #860      +/-   ##
==========================================
- Coverage   34.66%   34.14%   -0.52%     
==========================================
  Files          61       62       +1     
  Lines        4050     4129      +79     
==========================================
+ Hits         1404     1410       +6     
- Misses       2424     2497      +73     
  Partials      222      222              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fmartingr
Copy link
Member

Hey @PterX I see you keep updating with latest master, did you missed this comment I made back in the day? It doesn't have to be authelia but some service to easily test this locally or in e2e tests (#816)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants