Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readme update, version bump, mod update #344

Merged
merged 1 commit into from
May 21, 2020
Merged

readme update, version bump, mod update #344

merged 1 commit into from
May 21, 2020

Conversation

jeevatkm
Copy link
Member

@jeevatkm jeevatkm commented May 19, 2020

For release v2.3.0

@jeevatkm jeevatkm self-assigned this May 19, 2020
@jeevatkm jeevatkm added this to the v2.3.0 Milestone milestone May 19, 2020
@codecov
Copy link

codecov bot commented May 19, 2020

Codecov Report

Merging #344 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #344   +/-   ##
=======================================
  Coverage   96.17%   96.17%           
=======================================
  Files          10       10           
  Lines        1228     1228           
=======================================
  Hits         1181     1181           
  Misses         26       26           
  Partials       21       21           
Impacted Files Coverage Δ
resty.go 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 986808a...30fb8f6. Read the comment docs.

README.md Outdated
@@ -131,6 +131,7 @@ fmt.Println("Response Info:")
fmt.Println("Error :", err)
fmt.Println("Status Code:", resp.StatusCode())
fmt.Println("Status :", resp.Status())
fmt.Println("Proro :", resp.Proto())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/Proro/Proto/

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected.

@jeevatkm jeevatkm force-pushed the release-prep branch 2 times, most recently from b2d86cd to 8644b1e Compare May 21, 2020 04:26
README.md Outdated
@@ -154,27 +156,29 @@ Response Info:
Error : <nil>
Status Code: 200
Status : 200 OK
Time : 465.301137ms
Received At: 2019-06-16 01:52:33.772456 -0800 PST m=+0.466672260
Proro : HTTP/2.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/Proro/Proto/g

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again. I missed one more spot 🤦

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected.

@jeevatkm jeevatkm merged commit 19d4968 into master May 21, 2020
@jeevatkm jeevatkm deleted the release-prep branch May 21, 2020 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants