Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TraceInfo on failed connections #342

Merged
merged 2 commits into from
May 14, 2020
Merged

Fix TraceInfo on failed connections #342

merged 2 commits into from
May 14, 2020

Conversation

moorereason
Copy link
Contributor

@moorereason moorereason commented May 13, 2020 •
edited by jeevatkm
Loading

Close #338

@moorereason
Fix TraceInfo on failed connections
6467230 
Only calculate TCPConnTime, ConnTime, and ResponseTime for successful
connections.

Fixes go-resty#338
@moorereason
Sequentially sort clientTrace struct members
2214d44 
Sort clientTrace struct members based upon the normaly trace hook
execution sequence.
@codecov
Copy link

codecov bot commented May 13, 2020 •
edited
Loading

Codecov Report

Merging #342 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #342      +/-   ##
==========================================
+ Coverage   96.16%   96.17%   +0.01%     
==========================================
  Files          10       10              
  Lines        1224     1228       +4     
==========================================
+ Hits         1177     1181       +4     
  Misses         26       26              
  Partials       21       21
Impacted Files Coverage Δ
trace.go 100.00% <ø> (ø)
request.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7fae0d...2214d44. Read the comment docs.

jeevatkm
jeevatkm approved these changes May 14, 2020
View reviewed changes
Copy link
Member

@jeevatkm jeevatkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@moorereason Thanks, looks good.

@jeevatkm jeevatkm merged commit 8a29e30 into go-resty:master May 14, 2020
@jeevatkm jeevatkm added bug v2 For resty v2 labels May 19, 2020
@jeevatkm jeevatkm added this to the v2.3.0 Milestone milestone May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeevatkm jeevatkm jeevatkm approved these changes

Assignees

@moorereason moorereason

Labels
bug v2 For resty v2
Milestone
v2.3.0 Milestone
Development

Successfully merging this pull request may close these issues.

incorrect traceinfo upon timeout
2 participants
@moorereason @jeevatkm