Implement adapter Name and add Name constant

[lafriks]

No description provided.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a660059) 82.81% compared to head (2362f6d) 83.45%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #85      +/-   ##
==========================================
+ Coverage   82.81%   83.45%   +0.64%     
==========================================
  Files           1        1              
  Lines         128      133       +5     
==========================================
+ Hits          106      111       +5     
  Misses         19       19              
  Partials        3        3              

Files	Coverage Δ
mssql.go	83.45% <100.00%> (+0.64%)	⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Fs02]

can you fix the code coverage?

[lafriks]

not really as it won't anyway correctly cover that case then, I can remove MustOpen :)

[Fs02]

you can do unit test trick like extracting the panic checking code
it's easier to maintain 100% coverage than just letting it drops

[lafriks]

I don't see reason to simulate code coverage percentage when actual case is not really checked

[Fs02]

it's to maintain code coverage
easier to enforce 100% code coverage policy than allowing coverage to be dropped case by case

what we do here is unit test, so IMO it's acceptable to do that, in fact we should make the code unit testable and sometimes it's required repeated refactoring

we must do actual case test when we are responsible for the logic, but for opening connection and etc, it's implemented by driver (and they are responsible for it) so it's okay to just simulate it

[Fs02]

IMO, this is not much different than when we mock functions to do unit test

[lafriks]

Fixed it a bit different by mocking db.Open and this way actually kind a testing that code path

[Fs02]

LGTM, Thanks
I really appreciate this