Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for column primary option #43

Merged
merged 2 commits into from
Nov 5, 2021

Conversation

lafriks
Copy link
Contributor

@lafriks lafriks commented Nov 4, 2021

Related to go-rel/rel#244

  • Fix table creation with empty column list
  • Sync with changes in go-rel/sql

* Fix table creation with empty column list
* Sync with changes in go-rel/sql
@codecov
Copy link

codecov bot commented Nov 4, 2021

Codecov Report

Merging #43 (8ea0ca1) into main (296cbd3) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #43   +/-   ##
=======================================
  Coverage   83.07%   83.07%           
=======================================
  Files           1        1           
  Lines         130      130           
=======================================
  Hits          108      108           
  Misses         19       19           
  Partials        3        3           
Impacted Files Coverage Δ
mssql.go 83.07% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 296cbd3...8ea0ca1. Read the comment docs.

@lafriks lafriks added the enhancement New feature or request label Nov 4, 2021
Copy link
Member

@Fs02 Fs02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯
(let's merge this after rel and sql is released)

@lafriks
Copy link
Contributor Author

lafriks commented Nov 5, 2021

updated, can be merged

@Fs02 Fs02 merged commit 307c4e7 into go-rel:main Nov 5, 2021
@lafriks lafriks deleted the feat/col_primary branch November 5, 2021 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants