-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update dependencies to latest versions #1339
Conversation
73437f7
to
ae55dab
Compare
4f95f97
to
709e955
Compare
@deankarn Is it ok to merge this PR? |
@nodivbyzero no because of:
|
709e955
to
04042d5
Compare
04042d5
to
7f58583
Compare
@deankarn I've updated my PR and removed the vendor folder. |
@nodivbyzero only that if anyone is still using Go 1.17 it would/could break people existing builds if we add anything that’s not backward compatible with 1.17 which is more likely than other version bumps because thats when generics were added. I would love to recommend others update to a newer version if in this situation but possible they can’t for some reason or other reasons. We can add more recent features though, without bumping a major version(which is a pain because of the way go versions > v1 is in the import path itself and is prolific down the dependency tree), by adding compile time directives. I can totally be convinced otherwise though and perhaps, for a future addition, can add to the README + docs that we support up to only say 3-4 version back from the latest. |
@deankarn Thank you for the detailed explanation. Here's a proposed plan:
What are your thoughts on this approach? |
@nodivbyzero it sounds reasonable, but I want to think about it for a little bit first as the one aspect that still bothers me is that bumping major versions in Go causes all package imports needing to be updated as well. This doesn’t sound like much when it’s a single project or repo, but even I have production code that spans many repos which updating like this becomes a major chore. Maybe not with this package specifically but I have seen subtle bugs and issues arise when you miss updating one of these imports in your dependency chain also when the package self-initializes/ is meant to be a singleton. (As a personal note I very much dislike how go has done this and IMO should have relied on the mod file to specify the version and not imports…) I have been and will continue to read about how others handle this. This is an old discussion for Rust not Go but highlight the same issues rust-lang/api-guidelines#123 |
Closing this PR in favor of the discussion at #1342 |
Fixes Or Enhances
go
ver. 1.23go
1.23@go-playground/validator-maintainers