-
-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a bug for sending cancel request to terminate a long running query #1952
Merged
elliotcourant
merged 9 commits into
go-pg:v10
from
xin-tsla:xin/v10-long-running-query-and-retry-condition
Aug 12, 2022
Merged
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
43ce189
Add for loop for checking if the query is finished or is cancelled
xin-tsla 08f646e
Rename a var from RetryStatementTimeout to RetryCancelledQuery and up…
xin-tsla 16654ae
Send a cancel request when there is a bad connection error
xin-tsla a976f9f
Rename a var back to RetryStatementTimeout
xin-tsla d4adb9e
Revert a change in withConn
xin-tsla f5953b1
Revert changes for comments
xin-tsla bc1d340
Add an unit test for testing sending a cancel request when a connecti…
xin-tsla 4030212
Change the return values of isBadConn to return error code if it has
xin-tsla f6a1a6c
Send a cancel request when it is a bad conn expect 25P02 case
xin-tsla File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -57,8 +57,8 @@ type Options struct { | |
// Maximum number of retries before giving up. | ||
// Default is to not retry failed queries. | ||
MaxRetries int | ||
// Whether to retry queries cancelled because of statement_timeout. | ||
RetryStatementTimeout bool | ||
// Whether to retry queries cancelled because of statement_timeout or cancel request. | ||
RetryCancelledQuery bool | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Renaming this would be a breaking change. I recommend we leave the name the same. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good point! I will revert the change to keep as it is. |
||
// Minimum backoff between each retry. | ||
// Default is 250 milliseconds; -1 disables backoff. | ||
MinRetryBackoff time.Duration | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this in a for loop? I looks like the previous logic would work. This appears to have this for loop run forever, as there is no way to break out of it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good point! My bad. Reverted the change.