Fix for #1832 Bazel build #1834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumped up testify t0 v1.7.0
|
Thanks. Will merge once https://github.com/open-telemetry/opentelemetry-go-contrib is ready. It usually takes a day or two. |
|
Great, thank you so much!
…On Tue, Feb 16, 2021, 15:04 Vladimir Mihailenco ***@***.***> wrote:
Thanks. Will merge once
https://github.com/open-telemetry/opentelemetry-go-contrib is ready. It
usually takes a day or two.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1834 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFYR7XAU5YFZ4KDXECGU46DS7IKGJANCNFSM4XVSWLHQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves #1832 (Failed Bazel build) by simply updating otel to 0.17.
No breaking changed detected, but waiting for CI & review.