-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(#210): Provide a method to return all headers (not only first header) of a given key #211
Conversation
… first header) for a given key in response.go Signed-off-by: Marcel Oenning <marcel.oenning@sap.com>
Signed-off-by: Marcel Oenning <marcel.oenning@sap.com>
Signed-off-by: Marcel Oenning <marcel.oenning@sap.com>
Signed-off-by: Marcel Oenning <marcel.oenning@sap.com>
In the test structures the GetHeaders function was missing. Can you rerun the workflow please? :) |
Signed-off-by: Marcel Oenning <marcel.oenning@sap.com>
Signed-off-by: Marcel Oenning <marcel.oenning@sap.com>
Should ClientResponse have a method to expose http.Response? If someone else want to handle special cases in the ClientResponse, the interface needs to be changed again. @casualjim I will let you decide. This code is ready to merge. |
@germanhs |
This is the fix for #210
It provides an additional method for the ClientResponse in response.go to retrieve all headers of a given key.
The current implementation only allows to retrieve the first header.
If you don't want to change the interface I would suggest to provide an extended version to which we can cast the Client Response.