Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify the logging format when debugging is enabled #118

Closed
hectorj2f opened this issue Sep 17, 2018 · 1 comment · Fixed by #282
Closed

Unify the logging format when debugging is enabled #118

hectorj2f opened this issue Sep 17, 2018 · 1 comment · Fixed by #282
Labels
debug pending PR

Comments

@hectorj2f
Copy link

When we enable the debug mode, it uses the logging format defined in the standardLogger (https://github.com/go-openapi/runtime/blob/master/middleware/context.go#L35). It'd be great to reuse the Logger defined when configuring the runtime.

Is it possible to unify the logger format when debug is enabled? Or I am missing something
kzys pushed a commit to kzys/runtime that referenced this issue Dec 17, 2022
@sipsma
Merge pull request go-openapi#118 from sipsma/master
03b790f 
Forward agent containerd events to shim and monitor task exits via event subscriptions
@fredbi fredbi added the debug label Dec 7, 2023
@fredbi
Copy link
Member

fredbi commented Dec 13, 2023

The runtime with an injectable Logger is for constructing a client.

On the server side, logging is scattered among different components so it's more difficult.

fredbi added a commit to fredbi/runtime that referenced this issue Dec 13, 2023
@fredbi
injectable logger in Context and DefaultRouter
a2dc915 
This PR allows to set a logger in Context and DefaultRouter.

* fixes go-openapi#118

Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
fredbi added a commit to fredbi/runtime that referenced this issue Dec 14, 2023
@fredbi
refactored debug logging
9a714db 
* relinted debugLog as debugLogf
* fixes go-openapi#244 (use logger.Debugf rather than logger.Printf)
* fixes go-openapi#118 (added support for injectable logger in Context and DefaultRouter)
* removed global debug logger

Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
@fredbi fredbi mentioned this issue Dec 14, 2023
Merged
fredbi added a commit that referenced this issue Dec 17, 2023
@fredbi
refactored debug logging
0d66801 
* relinted debugLog as debugLogf
* fixes #244 (use logger.Debugf rather than logger.Printf)
* fixes #118 (added support for injectable logger in Context and DefaultRouter)
* removed global debug logger

Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
debug pending PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix/debug issues fredbi/runtime
2 participants
@hectorj2f @fredbi