Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow timeout in connections, retries to be configurable #10

Merged
merged 2 commits into from
Dec 7, 2017
Merged

Allow timeout in connections, retries to be configurable #10

merged 2 commits into from
Dec 7, 2017

Conversation

ivy
Copy link

@ivy ivy commented Dec 7, 2017

Originally submitted by @connor4312 in go-gomail#70:

Previously if connections were unhealthy they could easily block up work, and there was no way to set read/write deadlines. This PR fixes that by adding a Timeout property on the Dialer, which is used for both the initial connection establishment and subsequent Send calls.

@ivy ivy merged commit 73cb68f into go-mail:master Dec 7, 2017
@ivy ivy deleted the user-defined-timeouts branch December 7, 2017 00:49
@ivy ivy mentioned this pull request Jan 27, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ivy @connor4312