Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

funcr: Handle nested empty groups properly #274

Merged
merged 2 commits into from
Mar 22, 2024
Merged

funcr: Handle nested empty groups properly #274

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a6645b7
Fix slog tests for 1.22
thockin Mar 1, 2024
376cba9
funcr: Handle nested empty groups properly
thockin Mar 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions slogr_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,7 @@ func TestRunSlogTestsOnSlogHandlerLogSink(t *testing.T) {
"a Handler should handle the WithGroup method",
"a Handler should handle multiple WithGroup and WithAttr calls",
"a Handler should not output groups for an empty Record",
"a Handler should not output groups if there are no attributes",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There might be a way to run the Slog tests as sub-tests now, golang/go#61758 got resolved. This might be a way to simplify this testing. Not important right now, just a thought.

"a Handler should call Resolve on attribute values in groups",
"a Handler should call Resolve on attribute values in groups from WithAttrs",
}
Expand Down