Add Proxied Authorization (RFC 4370), Who Am I? (RFC 4532) #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnweldon
reviewed
Apr 29, 2017
| "gopkg.in/ldap.v2" | ||
| ) | ||
|
|
||
| func ExampleWhoAmI() { |
There was a problem hiding this comment.
Are there tests for WhoAmI possible?
There was a problem hiding this comment.
I'll add a encode / decode test to control_test.go
also: fix typo: s/Authoization/Authorization/
|
... luckily the race fixed in #110 only happened in tip |
johnweldon
approved these changes
Oct 22, 2018
| // "A result code (123) has been assigned by the IANA for the case where | ||
| // the server does not execute a request using the proxy authorization | ||
| // identity." | ||
| LDAPResultAuthorizationDenied = 123 |
There was a problem hiding this comment.
I think these are already in now from PR #160
|
@vetinari I think this is the last one... any chance you still want to update this and we can get it merged in? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reworked #62