Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests to parseDN (fuzzing, roundtrip ...) #504

Merged
merged 2 commits into from
Apr 6, 2024

Conversation

inteon
Copy link
Contributor

@inteon inteon commented Apr 2, 2024

I additionally made some extra changes to the String() functions to make the round tripping work.
PTAL

NOTE: I think there might be a few changes that are not required but still included. I need some extra time to find them.
UPDATE: I removed the unnecessary code

@cpuschma

…d to make roundtripping work

Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
@inteon
Copy link
Contributor Author

inteon commented Apr 4, 2024

@cpuschma I updated the PR (removed the code that is not required for the roundtrip tests to pass)

@cpuschma
Copy link
Member

cpuschma commented Apr 4, 2024

I’ll look into this this weekend. Work’s been stressfull and I didn’t have the time to check your PR yet

Copy link
Member

@cpuschma cpuschma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll look into the BER decoding later and submit another PR, but that's not scope of this one. Thank you for your help! ♥

@cpuschma cpuschma merged commit 9c14185 into go-ldap:master Apr 6, 2024
22 checks passed
gustavoluvizotto pushed a commit to gustavoluvizotto/ldap-fork that referenced this pull request Apr 11, 2024
* add tests to parseDN (including fuzz tests) and apply changes required to make roundtripping work

Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>

* undo unnessary changes

Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>

---------

Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants