Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed local test suite by syncing MySQL and MariaDB versions from CircleCI config #425

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

jamius19
Copy link
Contributor

Goal

MySQL and MariaDB versions are not the same between .circleci/config.yml and tests/docker-compose.yaml, and as such, the local test suite fails on the master branch whereas it passes in CircleCI.

I've synced versions of MySQL and MariaDB databases so that local tests work correctly.
Please see Issue #423 for more context.

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.25%. Comparing base (5d2c232) to head (abb024a).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #425   +/-   ##
=======================================
  Coverage   91.25%   91.25%           
=======================================
  Files         134      134           
  Lines        7755     7755           
=======================================
  Hits         7077     7077           
  Misses        509      509           
  Partials      169      169           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@go-jet
Copy link
Owner

go-jet commented Nov 22, 2024

Thanks. Looks good.

@go-jet go-jet merged commit 3ca1776 into go-jet:master Nov 22, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants