Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

groot: fix go:generate portability for root-gen-type #952

Merged
merged 1 commit into from
Jun 23, 2022

Conversation

dolmen
Copy link
Contributor

@dolmen dolmen commented Jun 22, 2022

Use go run instead of requiring the binary to be already built.

@codecov-commenter
Copy link

Codecov Report

Merging #952 (01ac338) into main (8c3e3fa) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #952   +/-   ##
=======================================
  Coverage   72.57%   72.57%           
=======================================
  Files         410      410           
  Lines       62067    62067           
=======================================
  Hits        45044    45044           
  Misses      14692    14692           
  Partials     2331     2331           
Impacted Files Coverage Δ
groot/cmd/root-gen-type/main.go 20.65% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c3e3fa...01ac338. Read the comment docs.

Copy link
Member

@sbinet sbinet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sbinet sbinet merged commit ece275b into go-hep:main Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants