Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sliceop: use errors.New for constant errors #940

Merged
merged 1 commit into from
May 10, 2022
Merged

sliceop: use errors.New for constant errors #940

merged 1 commit into from
May 10, 2022

Conversation

dolmen
Copy link
Contributor

@dolmen dolmen commented Apr 27, 2022

Use errors.New instead of fmt.Errorf when the message is a constant string.

@dolmen
sliceop: use errors.New for constant errors
f17f497 
use errors.New instead of fmt.Errorf when the message is a constant
string.
@dolmen

This comment was marked as off-topic.

Sign in to view
sbinet
sbinet approved these changes Apr 28, 2022
View reviewed changes
Copy link
Member

@sbinet sbinet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sbinet sbinet merged commit 07f22fc into go-hep:main May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbinet sbinet sbinet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dolmen @sbinet