Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lhef: use errors.New instead of fmt.Errorf for constants #937

Merged
merged 1 commit into from
May 10, 2022
Merged

lhef: use errors.New instead of fmt.Errorf for constants #937

merged 1 commit into from
May 10, 2022

Conversation

dolmen
Copy link
Contributor

@dolmen dolmen commented Apr 27, 2022

Use errors.New instead of fmt.Errorf for constant messages.

sbinet
sbinet approved these changes Apr 28, 2022
View reviewed changes
Copy link
Member

@sbinet sbinet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

thanks for cleaning that up.

as per the contributing document, could you send another PR against go-hep/license repository, adding yourself to the AUTHORS and/or CONTRIBUTORS files?

thanks.

@sbinet
Copy link
Member

sbinet commented May 5, 2022

ping?

@sbinet
Copy link
Member

sbinet commented May 10, 2022

needs go-hep/license#14

@sbinet sbinet merged commit 163d127 into go-hep:main May 10, 2022
@sbinet
Copy link
Member

sbinet commented May 10, 2022

thanks for sticking with us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbinet sbinet sbinet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dolmen @sbinet