Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

groot: add read support for TCanvas #1002

Merged
merged 8 commits into from
Dec 6, 2023
Merged

Conversation

sbinet
Copy link
Member

@sbinet sbinet commented Dec 5, 2023

No description provided.

@sbinet sbinet force-pushed the groot-tcanvas branch 4 times, most recently from 1688b76 to 0206c72 Compare December 5, 2023 17:45
@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2023

Codecov Report

Attention: 88 lines in your changes are missing coverage. Please review.

Comparison is base (e73dd33) 72.88% compared to head (8af6fdd) 73.51%.

Files Patch % Lines
groot/rpad/pad.go 81.25% 18 Missing and 6 partials ⚠️
groot/rpad/canvas.go 73.91% 13 Missing and 5 partials ⚠️
groot/rpad/attcanvas.go 51.72% 11 Missing and 3 partials ⚠️
groot/riofs/walk.go 52.17% 11 Missing ⚠️
groot/rcmd/dump.go 40.00% 6 Missing and 3 partials ⚠️
groot/rbase/vpad.go 73.07% 5 Missing and 2 partials ⚠️
groot/rcmd/ls.go 91.66% 2 Missing and 1 partial ⚠️
groot/rbase/qobject.go 83.33% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1002      +/-   ##
==========================================
+ Coverage   72.88%   73.51%   +0.63%     
==========================================
  Files         420      426       +6     
  Lines       63821    65659    +1838     
==========================================
+ Hits        46514    48270    +1756     
- Misses      14913    14976      +63     
- Partials     2394     2413      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sbinet sbinet force-pushed the groot-tcanvas branch 5 times, most recently from 9076b0b to 726e1f5 Compare December 6, 2023 10:10
… T{Virtual,}Pad and TCanvas

Signed-off-by: Sebastien Binet <binet@cern.ch>
Signed-off-by: Sebastien Binet <binet@cern.ch>
Signed-off-by: Sebastien Binet <binet@cern.ch>
Signed-off-by: Sebastien Binet <binet@cern.ch>
Signed-off-by: Sebastien Binet <binet@cern.ch>
Signed-off-by: Sebastien Binet <binet@cern.ch>
Signed-off-by: Sebastien Binet <binet@cern.ch>
Signed-off-by: Sebastien Binet <binet@cern.ch>
@sbinet sbinet merged commit 8af6fdd into go-hep:main Dec 6, 2023
@sbinet sbinet deleted the groot-tcanvas branch December 6, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants