adjust auto rollup for CH 25.8 (int64 no longer is a string in json) #322
Conversation
Hedius
force-pushed
the
ch-25_8-remote-rollup-fix
branch
from
f4f5c8e to
22061be
Compare
|
Not sure why the pipeline failed? The code seems to work. Is what I did correct? |
| Age string `json:"age"` | ||
| Precision string `json:"precision"` | ||
| Age uint64 `json:"age"` | ||
| Precision uint64 `json:"precision"` |
There was a problem hiding this comment.
What about the ones still using CH pre 25.8? I think the best is to set output_format_json_quote_64bit_integers to false on the connection.
There was a problem hiding this comment.
People can also update their software^... At least when this is also in the next LTS release I think graphite-clickhouse should be compatible with it without any extra configuration
There was a problem hiding this comment.
nvm, 25.8 is a LTS release.
As I said. In my opinion, the software should work without any extra config params in the connection string, or server settings.
There was a problem hiding this comment.
I agree, therefore I suggested that G-CH would add the option to the connection, not that the user should add it (unless for now until G-CH is fixed).
| } | ||
|
|
||
| return Retention{Age: uint32(age), Precision: uint32(prec)}, nil | ||
| return Retention{Age: uint32(d.Age), Precision: uint32(d.Precision)}, nil |
There was a problem hiding this comment.
Maybe also update Retention to contain uint64 instead?
The makeRetention function could probably also be removed since it's not doing anything special anymore.
fixes #321
not tested atm.
This PR modifies the struct rollupRulesResponseRecord to use int64 for age and precision.
At the moment this is a string. With ClickHouse 25.8 this is now an integer in the JSON.