added metric for ooo lag for each datapoint #534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azhiltsov
approved these changes
Feb 14, 2023
timtofan
reviewed
Feb 14, 2023
timtofan
reviewed
Feb 14, 2023
deniszh
reviewed
Feb 14, 2023
deniszh
approved these changes
Feb 14, 2023
timtofan
reviewed
Feb 14, 2023
timtofan
reviewed
Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we receive OOO writes in graphite storage, we need to understand how far they are in the past in order to suggest possible solutions for OOO for cwhisper. In this PR I added prometheus histogram metric for OOO lag for each datapoint.
Tested on prod box, I didn't notice any performance impact