Fail migration with error if DB contains unknown migrations. #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If gormigrate finds migrations in the table that aren't in the provided list then it is likely the software is pointed at the wrong DB or somehow older code is running. Either way, we should not continue to work with this DB without human intervention.
mdales
force-pushed
the
mwd-error-on-unknown-migration
branch
from
a712055 to
6746c35
Compare
|
Hi @mdales, Thanks for opening this pull request! I have mixed feeling for this proposal. I agree that this may be useful for some people, but I think we should have a flag to enable this, and it should default to There's two reasons for this:
|
|
Thanks for the feedback @andreynering, much appreciated. Happy to add the flag with an off default, will update the PR shortly (along with additional tests). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If gormigrate finds migrations in the DB table that aren't in the code provided list then it is likely the software is pointed at the wrong DB or somehow older code is running. Either way, we should not continue to work with this DB without human intervention.
I actually hit this in a production situation, and it was confusing as to why things were failing down the line (as the DB didn't match the model). I'd like to make it an explicit failure rather than something caught later.
Very happy to fix/improve things