Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: coverage for duplicated key err #6389

Merged
merged 4 commits into from
Jun 10, 2023

Conversation

saeidee
Copy link
Member

@saeidee saeidee commented Jun 7, 2023

  • Do only one thing
  • Non breaking API changes
  • Tested

What did this pull request do?

Test coverage for ErrDuplicatedKey, related issue: #6345

@saeidee saeidee requested a review from a631807682 June 7, 2023 16:43
@saeidee saeidee changed the title Test coverage for duplicated key err test: coverage for duplicated key err Jun 7, 2023
@saeidee
Copy link
Member Author

saeidee commented Jun 7, 2023

Seems like the tests are failing for sqlserver, I will fix that.

@saeidee saeidee force-pushed the test-coverage-for-duplicated-key-err branch 8 times, most recently from ae0f247 to bbbdc43 Compare June 8, 2023 21:26
@saeidee saeidee force-pushed the test-coverage-for-duplicated-key-err branch from bbbdc43 to 31da562 Compare June 8, 2023 21:31
@saeidee
Copy link
Member Author

saeidee commented Jun 8, 2023

@a631807682 here is the fix PR for sqlserver driver go-gorm/sqlserver#103, shall we move with this PR?

@saeidee saeidee force-pushed the test-coverage-for-duplicated-key-err branch from 8efeb48 to e188b4b Compare June 9, 2023 07:17
@saeidee saeidee requested a review from a631807682 June 9, 2023 07:18
@saeidee saeidee force-pushed the test-coverage-for-duplicated-key-err branch from e188b4b to b9144dd Compare June 9, 2023 07:18
@ncruces
Copy link
Contributor

ncruces commented Jun 29, 2023

@saeidee can you please take a look at #6435?
I don't know how best to fix this.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants