Skip to content
This repository has been archived by the owner on Jun 8, 2019. It is now read-only.

Add new field "Empty" to Repository structure #56

Merged
merged 3 commits into from
May 4, 2017
Merged

Add new field "Empty" to Repository structure #56

merged 3 commits into from
May 4, 2017

Conversation

lafriks
Copy link
Member

@lafriks lafriks commented May 4, 2017

Add new field where to return repo.IsBare boolean from Gitea API

@bkcsoft
Copy link
Member

bkcsoft commented May 4, 2017

IsBare is a very specific thing, and not to be confused with a repo being empty :)

But LGTM 👍

@lunny
Copy link
Member

lunny commented May 4, 2017

Why it's a string type not a bool?

@lafriks
Copy link
Member Author

lafriks commented May 4, 2017

ouch, sry, fixed to boolean

@bkcsoft bkcsoft mentioned this pull request May 4, 2017
Merged
@lunny
Copy link
Member

lunny commented May 4, 2017

LGTM

@lunny
Copy link
Member

lunny commented May 4, 2017

No empty in github's API v3.

@guyzmo
Copy link

guyzmo commented May 4, 2017

@lunny indeed there's no empty, I use size from that API. I like the empty property, as it makes it explicit when you read the code.

@guyzmo
Copy link

guyzmo commented May 4, 2017

cf the following tickets on gogs:

@lunny lunny merged commit 59cdd51 into go-gitea:master May 4, 2017
@guyzmo guyzmo mentioned this pull request May 4, 2017
Merged
guyzmo added a commit to guyzmo/git-repo that referenced this pull request May 4, 2017
@guyzmo
🚒 Fixes cloning empty repositories
b260b2c 
for Gogs/Gitea, API is not yet out, cf following PRs:

cf unfoldingWord-dev/python-gitea-client#9
cf go-gitea/go-sdk#56
cf gogs/gogs#4484
cf gogs/go-gogs-client#64
cf https://github.com/gogits/gogs/pull/4484o

fixes #129
guyzmo added a commit to guyzmo/git-repo that referenced this pull request May 4, 2017
@guyzmo
🚒 Fixes cloning empty repositories
e37fc3d 
for Gogs/Gitea, API is not yet out, cf following PRs:

cf unfoldingWord-dev/python-gitea-client#9
cf go-gitea/go-sdk#56
cf gogs/gogs#4484
cf gogs/go-gogs-client#64
cf gogs/gogs#4484

fixes #129
guyzmo added a commit to guyzmo/git-repo that referenced this pull request May 4, 2017
@guyzmo
🚒 Fixes cloning empty repositories
a79d46f 
for Gogs/Gitea, API is not yet out, cf following PRs:

cf unfoldingWord-dev/python-gitea-client#9
cf go-gitea/go-sdk#56
cf go-gitea/gitea#1668
cf gogs/gogs#4484
cf gogs/go-gogs-client#64

fixes #129
@sapk sapk mentioned this pull request May 14, 2017
Closed
7 tasks
sapk added a commit to sapk-fork/gitea that referenced this pull request May 14, 2017
@sapk
re-Generate swagger.json
3127047 
changes introduced to repo format by : go-gitea#1687 go-gitea/go-sdk#58  go-gitea#1668 go-gitea/go-sdk#56
@sapk sapk mentioned this pull request May 14, 2017
Merged
appleboy pushed a commit to go-gitea/gitea that referenced this pull request May 14, 2017
@sapk @appleboy
re-Generate swagger.json (#1722)
91417e9 
changes introduced to repo format by : #1687 go-gitea/go-sdk#58  #1668 go-gitea/go-sdk#56
@sapk sapk mentioned this pull request Feb 25, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
kind/feature lgtm/done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lafriks @bkcsoft @lunny @guyzmo @tboerger