Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compare bug #9808

Merged
merged 2 commits into from
Jan 16, 2020
Merged

Fix compare bug #9808

merged 2 commits into from
Jan 16, 2020

Conversation

lunny
Copy link
Member

@lunny lunny commented Jan 16, 2020

As title.

@lunny lunny added this to the 1.12.0 milestone Jan 16, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 16, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 16, 2020
@6543
Copy link
Member

6543 commented Jan 16, 2020

@lunny just need a branch-"update"

@codecov-io
Copy link

Codecov Report

Merging #9808 into master will decrease coverage by 0.05%.
The diff coverage is 82.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9808      +/-   ##
==========================================
- Coverage   42.28%   42.22%   -0.06%     
==========================================
  Files         603      603              
  Lines       78864    78881      +17     
==========================================
- Hits        33344    33306      -38     
- Misses      41425    41500      +75     
+ Partials     4095     4075      -20
Impacted Files Coverage Δ
services/mailer/mail.go 46.52% <0%> (ø) ⬆️
modules/notification/webhook/webhook.go 37.97% <100%> (ø) ⬆️
modules/notification/action/action.go 35.65% <100%> (ø) ⬆️
services/pull/merge.go 51.02% <100%> (+0.68%) ⬆️
services/pull/check.go 56.64% <100%> (+3.26%) ⬆️
modules/notification/base/null.go 62.5% <100%> (ø) ⬆️
modules/notification/notification.go 73.33% <100%> (ø) ⬆️
modules/notification/mail/mail.go 24.63% <100%> (ø) ⬆️
modules/notification/ui/ui.go 74.46% <100%> (ø) ⬆️
modules/setting/queue.go 78.18% <73.33%> (-1.23%) ⬇️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd1a44e...bf99ba7. Read the comment docs.

@lafriks lafriks merged commit d3468ed into go-gitea:master Jan 16, 2020
@lafriks
Copy link
Member

lafriks commented Jan 16, 2020

Please send backports

@lafriks lafriks mentioned this pull request Jan 16, 2020
Closed
7 tasks
@lunny lunny deleted the lunny/fix_compare branch January 17, 2020 00:50
lunny added a commit to lunny/gitea that referenced this pull request Jan 17, 2020
@lunny @techknowlogick
Fix compare (go-gitea#9808)
8d1ad5d 
Co-authored-by: techknowlogick <matti@mdranta.net>
@lunny lunny mentioned this pull request Jan 17, 2020
Merged
lunny added a commit to lunny/gitea that referenced this pull request Jan 17, 2020
@lunny @techknowlogick
Fix compare (go-gitea#9808)
007e2c1 
Co-authored-by: techknowlogick <matti@mdranta.net>
@lunny lunny mentioned this pull request Jan 17, 2020
Merged
@lunny lunny added the backport/done All backports for this PR have been created label Jan 17, 2020
lunny added a commit that referenced this pull request Jan 17, 2020
@lunny @techknowlogick
Fix compare (#9808) (#9815)
ed6a2f2 
Co-authored-by: techknowlogick <matti@mdranta.net>

Co-authored-by: techknowlogick <matti@mdranta.net>
lunny added a commit that referenced this pull request Jan 17, 2020
@lunny @techknowlogick
Fix compare (#9808) (#9814)
e2ddc42 
Co-authored-by: techknowlogick <matti@mdranta.net>

Co-authored-by: techknowlogick <matti@mdranta.net>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@zeripath zeripath zeripath approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.
7 participants
@lunny @6543 @codecov-io @lafriks @zeripath @GiteaBot @techknowlogick