Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move repoWorkPool outside rename/transfer repository #9086

Merged
merged 10 commits into from
Dec 6, 2019

Conversation

lunny
Copy link
Member

@lunny lunny commented Nov 20, 2019

As title.

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Nov 20, 2019
"code.gitea.io/gitea/models"
"code.gitea.io/gitea/modules/notification"
"github.com/unknwon/com"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

space between these two imports

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 20, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 20, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 29, 2019
@codecov-io
Copy link

codecov-io commented Nov 29, 2019

Codecov Report

Merging #9086 into master will increase coverage by 0.01%.
The diff coverage is 41.93%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9086      +/-   ##
==========================================
+ Coverage   41.03%   41.04%   +0.01%     
==========================================
  Files         556      556              
  Lines       72535    72531       -4     
==========================================
+ Hits        29766    29773       +7     
+ Misses      39023    39016       -7     
+ Partials     3746     3742       -4
Impacted Files Coverage Δ
models/pull.go 55.26% <100%> (ø) ⬆️
models/repo.go 47.67% <6.66%> (-0.15%) ⬇️
services/repository/transfer.go 66.66% <70%> (+26.66%) ⬆️
models/repo_redirect.go 67.85% <75%> (+14.01%) ⬆️
modules/task/migrate.go 25% <0%> (-3.95%) ⬇️
models/pull_list.go 57.74% <0%> (-2.12%) ⬇️
models/error.go 32.67% <0%> (-1.79%) ⬇️
models/issue.go 52.1% <0%> (+0.24%) ⬆️
modules/migrations/gitea.go 9.45% <0%> (+0.63%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ff5b75...3f406c4. Read the comment docs.

@lunny lunny merged commit 77730db into go-gitea:master Dec 6, 2019
@lunny lunny deleted the lunny/move_rename branch December 6, 2019 04:00
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants