Unescape wiki filename string

[Tekaoh]

This pull request allows wiki pages with special characters in the title to be accessed.

Fixes #8284

[Tekaoh]

Hmm... This builds on my machine. I'll have to figure out what I did wrong to make the test build fail... Sorry about that

[Tekaoh]

Well, now I'm not too sure what... Maybe someone has a suggestion

[guillep2k]

It's failing the unit test TestEditWikiPost():

Are you able to run that test it in your computer?

[guillep2k]

You can test it yourself using:

cd routers/repo
go test -tags="sqlite sqlite_unlock_notify" -run TestEditWikiPost

Or even better:

TAGS="sqlite sqlite_unlock_notify" make clean generate test

(that would run all unit tests, but not the integration tests).

[Tekaoh]

@guillep2k Thanks for the tip!

I think I've worked out a better solution. Basically the issue is that when WikiNameToFilename() passes the name through url.QueryEscape(), it actually no longer matches the filename in cases where there are special characters in the name. But the unit test has a fit when it's not there. So I added url.QueryUnescape() to wikiContentsByName() to correct any special characters later so that these pages can be accessed.

[codecov-io]

Codecov Report

Merging #8374 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #8374      +/-   ##
==========================================
- Coverage    41.8%   41.79%   -0.01%     
==========================================
  Files         496      496              
  Lines       65586    65586              
==========================================
- Hits        27418    27412       -6     
- Misses      34655    34659       +4     
- Partials     3513     3515       +2

Impacted Files	Coverage Δ
routers/repo/wiki.go	40.88% <100%> (ø)	⬆️
modules/process/manager.go	76.81% <0%> (-4.35%)	⬇️
models/gpg_key.go	55.83% <0%> (-0.84%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb7c23f...ccd0ea8. Read the comment docs.

[guillep2k]

No worries.
Now your PR passes the tests, but the CI got stuck on 'notify'. Somebody will look into that.

[lunny]

@Tekaoh could you add a unit test?

[Tekaoh]

@lunny I wouldn't know how, or even really what that means lol... I just took a try at fixing the bug I found. My commit fixes it, but I'm not entirely sure about all the correct procedures...

[lunny]

@Tekaoh You can find many example on https://github.com/go-gitea/gitea/blob/master/models/wiki_test.go#L33 and I think it's not complicated.

[Tekaoh]

I did some deeper digging and found that this PR is not going to be a good solution. I am therefore going to just close it for now and have another pass at it.

Please see my explanation at #8284 (comment)