Backport: add reviewers as participants #8124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lafriks
approved these changes
Sep 7, 2019
GiteaBot
added
the
lgtm/need 1
|
|
|
I already set so |
adelowo
approved these changes
Sep 7, 2019
GiteaBot
added
lgtm/done
lunny
added
the
status/blocked
lunny
removed
the
status/blocked
|
I guess the build failing is a CI problem? |
|
I think the swagger/gomod changes that were made to master, may need to be backported first. cc: @sapk |
|
|
|
@lunny you can see that swagger command modifies go.mod, which causes make vendor to fail. |
Merged
…ue-participants-v1.9
…tea into fix-issue-participants-v1.9
|
I think this needs #8087 backported. |
|
@guillep2k backport is done. |
|
Make LG-TM work |
lunny
reviewed
Sep 13, 2019
| if !isAdded && !issue.IsPoster(comment.Poster.ID) { | ||
| participants = append(participants, comment.Poster) | ||
| } | ||
| participants = addParticipant(comment.Poster, participants) |
There was a problem hiding this comment.
The issue Poster should not be added to participants according before logic.
if !issue.IsPoster(comment.Poster.ID) {
participants = addParticipant(comment.Poster, participants)
}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport for #8121
This PR add reviewers to the list of participants of an issue.
Currently, only users that add a plain comment (CommentTypeComment) are counted as participants. If a user adds a review/request changes (CommentTypeReview or CommentTypeCode) they are not considered participants.
Fixes #8122