Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update npm dependencies and various tweaks #7344

Merged
merged 2 commits into from
Jul 2, 2019

Conversation

silverwind
Copy link
Member

  • ran make npm-update
  • ran make js, fixed new lint issue
  • ran make css, this added back some vendor prefixes
  • added engines property to package.json to specify minimum required Node.js version
  • added private property to package.json to prevent accidential publishing to npm

- ran `make npm-update`
- ran `make js`, fixed new lint issue
- ran `make css`, this added back some vendor prefixes
- added `engines` property to package.json to specify minimum required
  Node.js version
- added `private` property to package.json to prevent accidential
  publishing to npm
.tab-size-13{-moz-tab-size:13!important;-o-tab-size:13!important;tab-size:13!important}
.tab-size-14{-moz-tab-size:14!important;-o-tab-size:14!important;tab-size:14!important}
.tab-size-15{-moz-tab-size:15!important;-o-tab-size:15!important;tab-size:15!important}
.tab-size-16{-moz-tab-size:16!important;-o-tab-size:16!important;tab-size:16!important}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zeripath they are back again, and should hopefully stay now that we lock dependencies.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 2, 2019
@silverwind silverwind changed the title update dependencies and various tweaks update npm dependencies and various tweaks Jul 2, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 2, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 2, 2019
@zeripath zeripath added this to the 1.9.0 milestone Jul 2, 2019
@codecov-io
Copy link

Codecov Report

Merging #7344 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7344      +/-   ##
==========================================
- Coverage   41.25%   41.25%   -0.01%     
==========================================
  Files         467      467              
  Lines       63291    63291              
==========================================
- Hits        26113    26108       -5     
- Misses      33762    33767       +5     
  Partials     3416     3416
Impacted Files Coverage Δ
models/unit.go 62.16% <0%> (-5.41%) ⬇️
modules/process/manager.go 76.81% <0%> (-4.35%) ⬇️
modules/log/event.go 64.61% <0%> (-1.03%) ⬇️
models/repo_list.go 73.09% <0%> (+1.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c39df04...54f5d0a. Read the comment docs.

@zeripath zeripath merged commit 68ec7b8 into go-gitea:master Jul 2, 2019
@silverwind silverwind deleted the update-deps branch July 3, 2019 16:13
jeffliu27 pushed a commit to jeffliu27/gitea that referenced this pull request Jul 18, 2019
- ran `make npm-update`
- ran `make js`, fixed new lint issue
- ran `make css`, this added back some vendor prefixes
- added `engines` property to package.json to specify minimum required
  Node.js version
- added `private` property to package.json to prevent accidential
  publishing to npm
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants